search

rcornwell / sims

Burroughs B5500, ICL1900, SEL32, IBM 360/370, IBM 7000 and DEC PDP10 KA10/KI10/KL10/KS10, PDP6 simulators for SimH
http://sky-visions.com
95 stars 20 forks source link

KA10: ITS build broken on Travis CI servers. #232

Closed larsbrinkhoff closed 3 years ago

larsbrinkhoff commented 3 years ago

Commit fdf17b80a1725a0d5c14beb89bd9ee1dd5d5f696 was the last to work with the ITS build script running on the Travis CI servers. The next commit e4882ce3bc5c51b3f76c7214931be572f611f5c8 broke the build. By reverting pieces of e488 I have determined that the move of sim_process_event in the indirect loop is the cause. If I move those lines outside the if statement, c488 will work again.

I am in the process of testing this against the latest master commit. I will post the result here.

larsbrinkhoff commented 3 years ago

Link to the code I found: https://github.com/rcornwell/sims/commit/e4882ce3bc5c51b3f76c7214931be572f611f5c8#r46747511

larsbrinkhoff commented 3 years ago

This is the patch on top of latest master that I'm testing now: https://github.com/larsbrinkhoff/ka10-simh/commit/2a7b71ced15201020f600a4d7d9852a01edd75f5

larsbrinkhoff commented 3 years ago

Seems to be a success: https://travis-ci.org/github/PDP-10/its/builds/757551633

larsbrinkhoff commented 3 years ago

Updated to clarify the build failure is on Travis CI. Other machines seem to work fine.

larsbrinkhoff commented 3 years ago

Rebased on top of latest master commits. Tested ok on Travis CI: https://travis-ci.org/github/PDP-10/its/builds/757661693

larsbrinkhoff commented 3 years ago

Also confirmed that latest master breaks Travis CI without the patch: https://travis-ci.org/github/PDP-10/its/builds/757666374

larsbrinkhoff commented 3 years ago

Rebased.

Current master still doesn't agree with Travis: https://travis-ci.org/github/PDP-10/its/builds/758183636
With patch: https://travis-ci.org/github/PDP-10/its/builds/758186851

larsbrinkhoff commented 3 years ago

@rcornwell, your commit 2e12cd553 moves the call to check_irq_level. I tested this, but it's still not enough to make Travis happy: https://travis-ci.org/github/PDP-10/its/builds/758329961

larsbrinkhoff commented 3 years ago

Rebased my patch. Travis build: https://travis-ci.org/github/PDP-10/its/builds/758342045

larsbrinkhoff commented 3 years ago

Latest master commit works now. Thanks!