Open cmgauger opened 1 week ago
Just a quick follow up, here's the warning and error log "cleaned up" to remove most of the cruft; I marked the issues fixed by Lars' PR and the upstream sim_timer.c
by tacking the word "FIXED
" in front.
Errors I marked with three asterisks.
PDP10-KL
kl10_dn.c(406): warning C4102: 'enter_pri' : unreferenced label
kl10_dn.c(368): warning C4101: 'ch' : unreferenced local variable
kl10_dn.c(656): warning C4101: 'ch' : unreferenced local variable
kl10_dn.c(717): warning C4101: 'otty' : unreferenced local variablej]
kl10_dn.c(908): warning C4101: 'data1' : unreferenced local variable
kl10_dn.c(910): warning C4101: 'n' : unreferenced local variable
kl10_dn.c(912): warning C4101: 'save_ptr' : unreferenced local variable
kl10_dn.c(911): warning C4101: 'ln' : unreferenced local variable
kl10_dn.c(909): warning C4101: 'dataq' : unreferenced local variable
kl10_dn.c(913): warning C4101: 'ch' : unreferenced local variable
kl10_dn.c(1035): warning C4101: 'ch' : unreferenced local variable
FIXED sim_timer.c(1844): warning C4101: 'tmr' : unreferenced local variable
PDP10-KA
FIXED ka10_dd.c(389): warning C4101: 'j' : unreferenced local variable
FIXED ka10_dd.c(519): warning C4244: '=' : conversion from 'uint64' to 'int32', possible loss of data
FIXED ka10_dd.c(544): warning C4018: '>=' : signed/unsigned mismatch
FIXED ka10_dd.c(657): warning C4244: '=' : conversion from 't_value' to 'int', possible loss of data
FIXED ka10_dd.c(729): warning C4244: '=' : conversion from 'uint64' to 'uint32', possible loss of data
FIXED sim_timer.c(1844): warning C4101: 'tmr' : unreferenced local variable
B5500
FIXED sim_timer.c(1844): warning C4101: 'tmr' : unreferenced local variable
I704
FIXED sim_timer.c(1844): warning C4101: 'tmr' : unreferenced local variable
I7070
FIXED sim_timer.c(1844): warning C4101: 'tmr' : unreferenced local variable
I7010
FIXED sim_timer.c(1844): warning C4101: 'tmr' : unreferenced local variable
I7090
FIXED sim_timer.c(1844): warning C4101: 'tmr' : unreferenced local variable
*** C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(113,5): error MSB3073: The command "Post-Build-Event.cmd I7000 " C:\src\sim\rcornwell-simh\BIN\NT\Win32-Release\I7090.exe"\r [C:\src\sim\rcornwell-simh\Visual Studio Projects\I7090.vcxproj] C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(113,5): error MSB3073: :VCEnd" exited with code 1. [C:\src\sim\rcornwell-simh\Visual Studio Projects\I7090.vcxproj]
I7080
FIXED sim_timer.c(1844): warning C4101: 'tmr' : unreferenced local variable
PDP10-KI
FIXED kx10_tym.c(549): warning C4244: '=' : conversion from 'uint64' to 'int', possible loss of data
FIXED sim_timer.c(1844): warning C4101: 'tmr' : unreferenced local variable
PDP6
FIXED sim_timer.c(1844): warning C4101: 'tmr' : unreferenced local variable
IBM360
ibm360_cpu.c(3065): warning C4101: 't' : unreferenced local variable
FIXED sim_timer.c(1844): warning C4101: 'tmr' : unreferenced local variable
*** ibm360_lpr.c(495): error C2143: syntax error : missing ';' before 'type'
*** ibm360_lpr.c(497): error C2065: 'f' : undeclared identifier
*** ibm360_lpr.c(499): error C2065: 'f' : undeclared identifier
I701
FIXED sim_timer.c(1844): warning C4101: 'tmr' : unreferenced local variable
SEL32
FIXED sim_timer.c(1844): warning C4101: 'tmr' : unreferenced local variable
*** sim_timer.c(1844): error C2220: warning treated as error - no 'object' file generated
ICL1900
FIXED sim_timer.c(1844): warning C4101: 'tmr' : unreferenced local variable
PDP10-KS
FIXED sim_timer.c(1844): warning C4101: 'tmr' : unreferenced local variable
*** kx10_sys.obj : error LNK2001: unresolved external symbol _ocnsls_dev
*** kx10_sys.obj : error LNK2001: unresolved external symbol _wcnsls_dev
*** kx10_sys.obj : error LNK2001: unresolved external symbol _dpy_dev
*** PDP10-KS.exe : fatal error LNK1120: 3 unresolved externals
The following three simulators fail to build:
Of which the SEL32 would be fixed by grabbing the upstream sim_timer.c
(or turning off the "warnings as errors" option in the build).
The I7090 builds, but the post-build testing phase (presumably) fails.
Update to go along with commit 9f663cb Visual Studio 2010 is giving 1 warning and 8 errors now:
Build FAILED.
"C:\src\sim\rcornwell-simh\Visual Studio Projects\Simh.sln" (Rebuild tar
get) (1) ->
"C:\src\sim\rcornwell-simh\Visual Studio Projects\IBM360.vcxproj" (Rebui
ld target) (12) ->
(ClCompile target) ->
..\IBM360\ibm360_cpu.c(3065): warning C4101: 't' : unreferenced local
variable [C:\src\sim\rcornwell-simh\Visual Studio Projects\IBM360.vcxpro
j]
"C:\src\sim\rcornwell-simh\Visual Studio Projects\Simh.sln" (Rebuild tar
get) (1) ->
"C:\src\sim\rcornwell-simh\Visual Studio Projects\IBM360.vcxproj" (Rebui
ld target) (12) ->
(ClCompile target) ->
..\IBM360\ibm360_lpr.c(495): error C2143: syntax error : missing ';' b
efore 'type' [C:\src\sim\rcornwell-simh\Visual Studio Projects\IBM360.vc
xproj]
..\IBM360\ibm360_lpr.c(497): error C2065: 'f' : undeclared identifier
[C:\src\sim\rcornwell-simh\Visual Studio Projects\IBM360.vcxproj]
..\IBM360\ibm360_lpr.c(499): error C2065: 'f' : undeclared identifier
[C:\src\sim\rcornwell-simh\Visual Studio Projects\IBM360.vcxproj]
"C:\src\sim\rcornwell-simh\Visual Studio Projects\Simh.sln" (Rebuild tar
get) (1) ->
"C:\src\sim\rcornwell-simh\Visual Studio Projects\I7090.vcxproj" (Rebuil
d target) (8) ->
(PostBuildEvent target) ->
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.
targets(113,5): error MSB3073: The command "Post-Build-Event.cmd I7000 "
C:\src\sim\rcornwell-simh\BIN\NT\Win32-Release\I7090.exe"\r [C:\src\sim\
rcornwell-simh\Visual Studio Projects\I7090.vcxproj]
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.ta
rgets(113,5): error MSB3073: :VCEnd" exited with code 1. [C:\src\sim\rco
rnwell-simh\Visual Studio Projects\I7090.vcxproj]
"C:\src\sim\rcornwell-simh\Visual Studio Projects\Simh.sln" (Rebuild tar
get) (1) ->
"C:\src\sim\rcornwell-simh\Visual Studio Projects\PDP10-KS.vcxproj" (Reb
uild target) (16) ->
(Link target) ->
kx10_sys.obj : error LNK2001: unresolved external symbol _ocnsls_dev [
C:\src\sim\rcornwell-simh\Visual Studio Projects\PDP10-KS.vcxproj]
kx10_sys.obj : error LNK2001: unresolved external symbol _wcnsls_dev [
C:\src\sim\rcornwell-simh\Visual Studio Projects\PDP10-KS.vcxproj]
kx10_sys.obj : error LNK2001: unresolved external symbol _dpy_dev [C:\
src\sim\rcornwell-simh\Visual Studio Projects\PDP10-KS.vcxproj]
..\BIN\NT\Win32-Release\PDP10-KS.exe : fatal error LNK1120: 3 unresolv
ed externals [C:\src\sim\rcornwell-simh\Visual Studio Projects\PDP10-KS.
vcxproj]
1 Warning(s)
8 Error(s)
Time Elapsed 00:01:21.62
Which in summary are:
IBM360
ibm360_cpu.c(3065): warning C4101: 't' : unreferenced local variable
*** ibm360_lpr.c(495): error C2143: syntax error : missing ';' before 'type'
*** ibm360_lpr.c(497): error C2065: 'f' : undeclared identifier
*** ibm360_lpr.c(499): error C2065: 'f' : undeclared identifier
I7090
*** C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(113,5): error MSB3073: The command "Post-Build-Event.cmd I7000 " C:\src\sim\rcornwell-simh\BIN\NT\Win32-Release\I7090.exe"\r [C:\src\sim\rcornwell-simh\Visual Studio Projects\I7090.vcxproj] C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(113,5): error MSB3073: :VCEnd" exited with code 1. [C:\src\sim\rcornwell-simh\Visual Studio Projects\I7090.vcxproj]
PDP10-KS
*** kx10_sys.obj : error LNK2001: unresolved external symbol _ocnsls_dev
*** kx10_sys.obj : error LNK2001: unresolved external symbol _wcnsls_dev
*** kx10_sys.obj : error LNK2001: unresolved external symbol _dpy_dev
*** PDP10-KS.exe : fatal error LNK1120: 3 unresolved externals
The errors are marked with "***
."
Next update for fa0d9b0 1 warning, 5 errors:
Build FAILED.
"C:\src\sim\rcornwell-simh\Visual Studio Projects\Simh.sln" (Rebuild tar
get) (1) ->
"C:\src\sim\rcornwell-simh\Visual Studio Projects\IBM360.vcxproj" (Rebui
ld target) (12) ->
(ClCompile target) ->
..\IBM360\ibm360_cpu.c(3065): warning C4101: 't' : unreferenced local
variable [C:\src\sim\rcornwell-simh\Visual Studio Projects\IBM360.vcxpro
j]
"C:\src\sim\rcornwell-simh\Visual Studio Projects\Simh.sln" (Rebuild tar
get) (1) ->
"C:\src\sim\rcornwell-simh\Visual Studio Projects\PDP10-KA.vcxproj" (Reb
uild target) (4) ->
(ClCompile target) ->
c1 : fatal error C1083: Cannot open source file: '..\PDP10\ka10_dpy.c'
: No such file or directory [C:\src\sim\rcornwell-simh\Visual Studio Pro
jects\PDP10-KA.vcxproj]
"C:\src\sim\rcornwell-simh\Visual Studio Projects\Simh.sln" (Rebuild tar
get) (1) ->
"C:\src\sim\rcornwell-simh\Visual Studio Projects\IBM360.vcxproj" (Rebui
ld target) (12) ->
..\IBM360\ibm360_lpr.c(495): error C2143: syntax error : missing ';' b
efore 'type' [C:\src\sim\rcornwell-simh\Visual Studio Projects\IBM360.vc
xproj]
..\IBM360\ibm360_lpr.c(497): error C2065: 'f' : undeclared identifier
[C:\src\sim\rcornwell-simh\Visual Studio Projects\IBM360.vcxproj]
..\IBM360\ibm360_lpr.c(499): error C2065: 'f' : undeclared identifier
[C:\src\sim\rcornwell-simh\Visual Studio Projects\IBM360.vcxproj]
"C:\src\sim\rcornwell-simh\Visual Studio Projects\Simh.sln" (Rebuild tar
get) (1) ->
"C:\src\sim\rcornwell-simh\Visual Studio Projects\I7090.vcxproj" (Rebuil
d target) (5) ->
(PostBuildEvent target) ->
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.
targets(113,5): error MSB3073: The command "Post-Build-Event.cmd I7000 "
C:\src\sim\rcornwell-simh\BIN\NT\Win32-Release\I7090.exe"\r [C:\src\sim\
rcornwell-simh\Visual Studio Projects\I7090.vcxproj]
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.ta
rgets(113,5): error MSB3073: :VCEnd" exited with code 1. [C:\src\sim\rco
rnwell-simh\Visual Studio Projects\I7090.vcxproj]
1 Warning(s)
5 Error(s)
Time Elapsed 00:01:19.24
And summary:
IBM360
ibm360_cpu.c(3065): warning C4101: 't' : unreferenced local variable
*** ibm360_lpr.c(495): error C2143: syntax error : missing ';' before 'type'
*** ibm360_lpr.c(497): error C2065: 'f' : undeclared identifier
*** ibm360_lpr.c(499): error C2065: 'f' : undeclared identifier
PDP10-KA
*** c1 : fatal error C1083: Cannot open source file: '..\PDP10\ka10_dpy.c' : No such file or directory
I7090
*** C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(113,5): error MSB3073: The command "Post-Build-Event.cmd I7000 " C:\src\sim\rcornwell-simh\BIN\NT\Win32-Release\I7090.exe"\r [C:\src\sim\rcornwell-simh\Visual Studio Projects\I7090.vcxproj] C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(113,5): error MSB3073: :VCEnd" exited with code 1. [C:\src\sim\rcornwell-simh\Visual Studio Projects\I7090.vcxproj]
As always, errors marked with three asterisks ("***
").
The following simulators build:
The following do not:
From my inexpert opinion, I believe that the PDP10-KA build error is because the vcxproj file is asking for ka10_dpy.c
when it should be kx10_dpy.c
instead.
Attempting to build the current master branch, under commit 4374b66, using Microsoft Visual Studio 2010 Ultimate's command line tools, I get the following build failure:
The warnings regarding
ka10_dd.c
andkx10_tym.c
can be ignored, as pull request 324 by Lars fixes them.Similarly, the C4101 for
sim_timer.c
can be ignored as the upstream version of Open SIMH has already fixed it.