search

rcos / observatory-server

A project tracking dashboard for Rensselaer Center for Open Source
https://rcos.io
MIT License
14 stars 51 forks source link

Code Quality for achievement.controller.js #734

Closed etran26 closed 6 years ago

etran26 commented 6 years ago

Changed 'var' to 'const' and replaced 'function' with new syntax '=>'

aeksco commented 6 years ago

@trane Ah! You really should be working on your dev branch. Try running git pull upstream dev and then doing git push origin master. Reach out to me if this creates any conflicts and I can help you get that squared away

aeksco commented 6 years ago

@trane2 I'll actually merge this one in since there's nothing here's that's causing problems - just make sure you open another PR with your changes to the classyear.controller.js file - thanks!