rcpch / digital-growth-charts-react-component-library

A typescript React library for displaying RCPCH Digital Growth Charts from API data
https://growth.rcpch.ac.uk
MIT License
7 stars 9 forks source link

Puberty region in height graphs blocked by grey box in Storybook #58

Closed dc2007git closed 5 months ago

dc2007git commented 11 months ago

On Storybook, when running the react-18-feature-test-branch, hovering below the puberty line elicits a filled box that pops up which blocks the screen. This happens between the precocious puberty line and post-17 completion delayed puberty.

Storybook CentileCharts affected: ‘With measurements from Birth Over Two Years’, ‘With Height and No Data’ (seems to be just the normal Height charts)

image
eatyourpeas commented 11 months ago

thanks @dc2007git for seeing this. Do you have any more information about your set up? It should look like this:

image

Are there any errors in the console? Which browser are you using?

dc2007git commented 11 months ago

Hi @eatyourpeas, no worries.

My setup is as follows:

No errors in the console as far as I can see. Just a warning about Storybook's add-on: CONSOLE OUTPUT: The "@storybook/addon-mdx-gfm" addon is meant as a migration assistant for Storybook 7.0; and will likely be removed in a future version.

Just tried again, same issue, both when hovering over the puberty region, and when outside of that shaded area but above 100cm Height/Length and between precocious puberty line and post-17 completion of puberty line. Once I start hovering on or above the 0.4th centile line, the box disappears.

eatyourpeas commented 5 months ago

Fixed and merged in v7.0.0. Documentation updated