search

rcpch / digital-growth-charts-react-component-library

A typescript React library for displaying RCPCH Digital Growth Charts from API data
https://growth.rcpch.ac.uk
MIT License
7 stars 9 forks source link

Testing for dGC Component Library #70

Closed dc2007git closed 5 months ago

dc2007git commented 7 months ago

It looks like there isn't a testing suite automatically executed on the Component Library upon PR submission, like with Epilepsy12.

For code safety reasons, this would be a good idea to implement and help ensure best CI/CD practices are being adhered to. Much like with Epilepsy12, it would also ensure that edge cases, dependency changes or any problems that would otherwise go missed are raised if adequate testing is in place.

At the moment Jest only has around ~20% code coverage for the component library, and while complete coverage shouldn't be our sole objective, we can afford to bump up the coverage numbers.

eatyourpeas commented 7 months ago

I second this. Jest has been included with Storybook in another branch with node bump and for next major release it seems to me we should include lots of tests.

eatyourpeas commented 5 months ago

Fixed and merged in v7.0.0. Documentation updated