Refactor props for styles - Githubissues

rcpch / digital-growth-charts-react-component-library

A typescript React library for displaying RCPCH Digital Growth Charts from API data

https://growth.rcpch.ac.uk

MIT License

7 stars 9 forks source link

Refactor props for styles #83

Closed dc2007git closed 5 months ago

dc2007git commented 5 months ago

[discussion on pairing session] Simon and I were having a discussion about styles. We spoke about the different styles, whether they are necessary, whether we should expose them to the user for customisation, and whether we should pass in only a theme prop as opposed to individual styles.

Points made:

The title should not be exposed for customisation (to maintain the data label (ie UKWHO), and the chart type (ie height/length)). The SUBTITLE however, can be exposed, as the integrators may want to place patient information such as NHS number.

eatyourpeas commented 5 months ago

Fixed and merged in v7.0.0. Documentation updated