rcpch / digital-growth-charts-react-component-library

A typescript React library for displaying RCPCH Digital Growth Charts from API data
https://growth.rcpch.ac.uk
MIT License
7 stars 11 forks source link

Implement deemphasised lines at nondisjunctions between references #98

Closed eatyourpeas closed 1 week ago

eatyourpeas commented 2 months ago

RCPCH Project Board 22.8.24

There has been longstanding confusion about the fact that centile lines between WHO and UK90 references do not line up. This is particularly seen in the head circumference chart where the overlap is of the order of 2 centiles.

Decision was therefore made to implement de-emphasised vertical lines at the join between references, with a tooltip to explain the discrepancy to users.

Vertical lines (grey / deemphasised, no prop) for all measurement methods at:

statist7 commented 2 months ago

Don't forget to include the disjunctions at 2 years for WHO height and BMI, due to the change from length to height.

eatyourpeas commented 1 month ago

Just to be clear - we always did have tool tips that appeared when users hovered over the breaks between references explaining the discrepancy and I have left those in. These extra lines are just clearer signposting.

image

especially for head circumference which initiated this issue.

image

If @statist7 agrees (and everyone else) I will merge this in.