search

rcpch / digital-growth-charts-server

RCPCH's open source Digital Growth Chart API
https://growth.rcpch.ac.uk/
GNU Affero General Public License v3.0
16 stars 11 forks source link

Do we need the term reference? #128

Closed eatyourpeas closed 3 years ago

eatyourpeas commented 3 years ago

At project board today the decision was made to correct for gestational age, even when term, across the life course. This now presents a dilemna with regard to the term reference, which has historically averaged the L, M and S across 37-42 weeks, and used this for all calculations over this time period. Centiles are not rendered over these weeks.

If age is now corrected, it would follow that the UK90 data be reinstated. Safeguards would be needed to make sure physiological weight loss in the first 2 weeks of life is accounted for.

eatyourpeas commented 3 years ago

Just to say that commit b5f3cc6cdbdd09ced9fa109e501cb81244915be0 in branch age-correction has removed the term reference. This branch has also removed all code limiting age correction, so this would now happen at any gestation across the life course. This change, if agreed by project board, therefore would also close issue #127.

pacharanero commented 3 years ago

Great stuff boss. This really is moving forward the state of the art in growth. Continuous gestational age correction!

BB-1313 commented 3 years ago

Seconded!

Simon were you surprised? You didn’t think this was likely last time it came up but it’s definitely a significant technical step forward to remove a convention like that and I’m sure it will simplify analysis and coding in the long run.

Is it worth putting an update on the thread on discourse to begin the necessary raising of awareness?

From: Marcus Baw [mailto:notifications@github.com] Sent: 27 January 2021 20:19 To: rcpch/digital-growth-charts-server digital-growth-charts-server@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [rcpch/digital-growth-charts-server] Do we need the term reference? (#128)

Great stuff boss. This really is moving forward the state of the art in growth. Continuous gestational age correction!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rcpch/digital-growth-charts-server/issues/128#issuecomment-768550976 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ARV7QELORDVYOVRBLHRGBHLS4BYL7ANCNFSM4WVHLODA . https://github.com/notifications/beacon/ARV7QEIPBBHJA3GKY3BGCV3S4BYL7A5CNFSM4WVHLODKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFXHSQQA.gif

eatyourpeas commented 3 years ago

thank you @BB-1313 yes I was surprised, but I think the project board saw it made sense when they saw the charts we had built. Electronic charting takes all the pain away and protects from human error. Why would you not correct if the computer will do it for you? Though I will still miss those paper charts in a nostalgic kind of way.

BB-1313 commented 3 years ago

We can have one framed once it’s all done and you can hang it on the wall for posterity!

I noticed your other comment about dealing with acceptable post-natal weight losses but that’s presumably relatively easy to flag at whatever level is conventional alongside the core function of charting/normalising from raw data?

It is also something that is still going to be largely a clinical responsibility to interpret from the chart so hopefully not a major clinical risk either way.

From: Simon Chapman [mailto:notifications@github.com] Sent: 27 January 2021 20:28 To: rcpch/digital-growth-charts-server digital-growth-charts-server@noreply.github.com Cc: Basil Basil.bekdash@gmail.com; Mention mention@noreply.github.com Subject: Re: [rcpch/digital-growth-charts-server] Do we need the term reference? (#128)

thank you @BB-1313 https://github.com/BB-1313 yes I was surprised, but I think the project board saw it made sense when they saw the charts we had built. Electronic charting takes all the pain away and protects from human error. Why would you not correct if the computer will do it for you? Though I will still miss those paper charts in a nostalgic kind of way.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rcpch/digital-growth-charts-server/issues/128#issuecomment-768555977 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ARV7QELRQYX7V7Q2SYWXNGLS4BZN3ANCNFSM4WVHLODA . https://github.com/notifications/beacon/ARV7QEIQCKV6BPMFSAD2O3DS4BZN3A5CNFSM4WVHLODKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFXHTXSI.gif

pacharanero commented 3 years ago

This is implemented in branch term-references-removed, and once we're happy with testing it will be merged into unstable

eatyourpeas commented 3 years ago

This was closed with PR af456e2