rcpch / digital-growth-charts-server

RCPCH's open source Digital Growth Chart API
https://growth.rcpch.ac.uk/
GNU Affero General Public License v3.0
16 stars 11 forks source link

Rcpch-private/32-normalise-the-script-naming-across-dgc-and-e12 #190

Closed pacharanero closed 8 months ago

eatyourpeas commented 1 year ago

before approving this @pacharanero can you confirm this won't break the start script on Azure?

pacharanero commented 1 year ago

I've checked and the startup command for production is totally different:

gunicorn --worker-tmp-dir /dev/shm rcpch-audit-engine.wsgi

eatyourpeas commented 1 year ago

I am getting an error: 2023-02-07 20:02:02 /bin/sh: 1: [: uvicorn: unexpected operator I am wondering if the line is not missing commas?: CMD [ "uvicorn" "main:app" "--reload" ]

pacharanero commented 1 year ago

Is this an error running locally? That syntax you're seeing is Dockerfile syntax. The Dockerfile is only used for local development. So it shouldn't affect the deployment, BUT of course I will want to investigate why you are getting a local error

eatyourpeas commented 1 year ago

Perhaps I am doing it wrong. Until now I have been running the server locally with s/run-development-server. Using your PR I have tried s/docker-rebuild on first use, and assumed it would be s/docker-start if ever needed. I cannot get that to work locally though and the error I get is the one I posted.