search

rcpch / national-paediatric-diabetes-audit

A django application to audit the care of children and young people with diabetes in England and Wales.
0 stars 1 forks source link

Eatyourpeas/issue96 #104

Closed eatyourpeas closed 3 weeks ago

eatyourpeas commented 3 weeks ago

Overview

Adds spinners to htmx request radio buttons and csv upload button

Code changes

Add daisyui spinner and css classes to show/hide + hyperscript

Related Issues

closes #96 #64

Mentions

@mentions of the person or team responsible for reviewing proposed changes.

mbarton commented 3 weeks ago

@eatyourpeas please could you add a more descriptive title to your PRs? :)

Even just copying the first line of the description. It really helps anyone who is looking at the GitHub notification stream or is going back through git blame or logs to investigate why something was added

eatyourpeas commented 3 weeks ago

I am so sorry yes of course - you have asked me to do this before. my bad. It is largely because I use VS Code for the PR workflow which prepopulates the title field and I am so focussed on writing a detailed PR that I forget the title. Apologies and will do better :)