rcpch / national-paediatric-diabetes-audit

A django application to audit the care of children and young people with diabetes in England and Wales.
0 stars 1 forks source link

Support GP postcode instead of ODS code in CSV uploads #213

Open eatyourpeas opened 3 months ago

eatyourpeas commented 3 months ago

In the current NPDA, users are encouraged to look up the ods code for a child's GP themselves here and then add that to their csv submission. A better implementation though would be to accept a GP postcode and retrieve the ODS code from the spine. There is a currently a function gp_practice_for_postcode which does this and works. We need to decide whether we continue to accept ods codes if supplied, or whether we also accept GP postcodes instead or both.

mbarton commented 3 months ago

@eatyourpeas is this for the CSV upload specifically? You can specify either in the UI. Linking this issue to #164 as the current lookup is fussy about spaces

eatyourpeas commented 3 months ago

sorry - yes, that was what i was thinking. NPDA team may tell us that changing the .csv layout is too much of a head ache to do this, so potentially it could just be an option in the UI. We could have a hybrid solution where ODS is an optional field in the csv, and could be updated in the UI optionally using the postcode