rcpch / national-paediatric-diabetes-audit

A django application to audit the care of children and young people with diabetes in England and Wales.
0 stars 1 forks source link

370 add the data quality report to the csv as a separate sheet #372

Closed reecehill closed 1 week ago

reecehill commented 1 week ago

This pull request includes significant refactoring and enhancements to the CSV handling functionality in the project/npda/general_functions module. The changes primarily focus on organizing the CSV-related functions into a dedicated subdirectory, adding new functionalities, and improving existing ones.

Key changes include:

Refactoring and Reorganization:

New Functionality:

Enhancements:

Bug Fixes:

Additional Improvements:

reecehill commented 1 week ago

Note to self:

Due to a circular import when importing project.npda.general_functions.csv_upload, I have:

  1. Moved csv-related functions into a submodule project.npda.general_functions.csv
  2. To further improve distinction between read_csv() pd.read_csv(),

    project.npda.general_functions.read_csv.read_csv()

    has been renamed (and moved) to

    project.npda.general_functions.csv.csv_parse.csv_parse()

mbarton commented 1 week ago

Seen on STAGING (created by @reecehill and merged by @eatyourpeas 7 minutes and 41 seconds ago) Please check your changes!