search

rcpch / national-paediatric-diabetes-audit

A django application to audit the care of children and young people with diabetes in England and Wales.
0 stars 1 forks source link

(Fixes #68) added main protection and run pytest on every push or merge #72

Closed NandaniThakur closed 1 month ago

NandaniThakur commented 1 month ago

In this PR, have changed the setting of repo, main branch to add rules for the protection of min branch. and created .github/workflows folders inside that created pytest.yml. in this file i have added code which will will trigger on every push or pull request to the main branch, install dependencies, and run Pytest.

Fixes https://github.com/rcpch/national-paediatric-diabetes-audit/issues/68

from my above mistake you might have guessed that I am new to open source. so, I will look forward to the feedbacks . If there is any correction please explain, that will help me understand the poblem.

eatyourpeas commented 1 month ago

Just in follow up to this - I ended up finding two issues: the first was that a bunch of dependencies were not loaded (relating to postgis) which caused the workflow to fail. The second was that the node version was deprecated, so full of warnings. In the end I reused a workflow from another project which dockerises the repo and pulls in a github secret which base64 encodes all the environment variables to allow the database to run and therefore the tests to run. This is all now working but when I tagged this as 'good first issue' that was possibly not that fair. Please do continue to contribute either to this repo or any of the others that RCPCH maintains and let me know if there is anyway we can support your journey through the world of open source. Thank you!

NandaniThakur commented 1 month ago

Thank you for your encouragement and advise. ill definitely keep that in mind always thrive for my open source journey. Thank You.