search

rcpch / national-paediatric-diabetes-audit

A django application to audit the care of children and young people with diabetes in England and Wales.
0 stars 1 forks source link

91 styling for tabs in visit form #93

Closed dc2007git closed 3 months ago

dc2007git commented 3 months ago

Adds error localisation capabilities to tabs on form as described in #91

If opening a new visit, the tabs will be white. If an error is present on the categories in the form, it will be red. If the contents of the tab have been validated, the tab will be pink.

Also in this PR is a boldening of the tab fonts:

image
dc2007git commented 3 months ago

@eatyourpeas if you're happy with this then feel free to merge! Otherwise any other design changes lmk and I can implement them

dc2007git commented 3 months ago

What do we think of this as error localisation on the form? The idea is to make it 'pop out':

image

I'm mindful that we want to keep theme consistent, and we use rcpch_red as our colour for red. As such, I've changed the background colour of 'Measurements' to be 'rcpch_vivid_green' instead of 'rcpch_red' so if an error pops up there, then it is more obvious.

dc2007git commented 3 months ago

@eatyourpeas it also looks like when editing a User's details, such as their employing organisation, saving does not work either - possibly something wrong with the update logic in both forms then. Will create an issue