rcpch / rcpch-audit-engine

Epilepsy12 Audit Platform
https://e12.rcpch.ac.uk/
GNU Affero General Public License v3.0
5 stars 5 forks source link

Fix showing child fields and submitting 5.2 and 5.3 #1068

Closed mbarton closed 1 month ago

mbarton commented 1 month ago

Fixes #1066 and #1067

1065 caused two bugs:

This was because the code hadn't been updated to account for choice fields always being strings and for adopting the string enum names from the old platform.

This PR fixes that and simplifies the code to check whether children of choice fields should render (by taking advantage of the fact both list and MSFList are iterable). As all the choices are now strings we can remove another integer conversion.

mbarton commented 1 month ago

Overdue on STAGING, LIVE (merged by @mbarton 30 minutes and 4 seconds ago) What's gone wrong?

mbarton commented 1 month ago

Seen on STAGING, LIVE (merged by @mbarton 31 minutes and 8 seconds ago) Please check your changes!