rcpch / rcpch-audit-engine

Epilepsy12 Audit Platform
https://e12.rcpch.ac.uk/
GNU Affero General Public License v3.0
5 stars 5 forks source link

Unclear on how to delete patients #769

Closed AmaniKrayemRCPCH closed 8 months ago

AmaniKrayemRCPCH commented 8 months ago

Just had a call from a user who kept being logged out when they tried to delete a patient. They said they would go to the patient's audit record, click 'delete' under secondary care centre, and then the platform would log them out.

Image

This user was from one of the sites that had multiple patients w/o organisations. I think that's the cause of that issue.

My suggestions: Maybe we should get rid of the 'delete' button under the secondary care centre. Is there a scenario where we'd delete but not transfer?

Another thought, maybe it should be clearer that these are two separate buttons? Maybe a gap between the buttons? Based on my call this morning, it seemed like the user hadn't realised that the 'edit' button leads to a different page.

Image

dc2007git commented 8 months ago

Hi @AmaniKrayemRCPCH, happy to look into this. Do you have any information regarding which type of user was experiencing this problem (ie lead clinician, clinician, admin)?

Looking at the edit/audit button, I agree I think they should be more separated! We can do that.

AmaniKrayemRCPCH commented 8 months ago

Heya. The user was a lead clinician

Apologies I forgot to note, they meant to delete the patient and not the patient's organisation. They hadn't realised that that the edit button leads to a different page and thought the only way to delete a patient was to remove their secondary care organisation. So yes a bug to fix but also a UI issue and probably why were getting patients disappearing from organisations.

i think i replicated this with patient 'Marley Cobb' on the staging site.

dc2007git commented 8 months ago

This is the new version of the button - a little more descriptive. Are you happy with this @AmaniKrayemRCPCH. Also, just for reference, the reason why the User was getting logged out was because he doesn't have permission to delete_lead_site - only the Audit Team does. So hopefully these buttons signpost to the user where they should go when they need to delete a child.

image

image

@eatyourpeas from Amani's issue above - do you think there is a situation in which the user would have to delete but not transfer patients from the secondary care field? As we could then conditionally render the button only for the Audit team members - as they are the only ones with permission to do so anyway

AmaniKrayemRCPCH commented 8 months ago

Happy with the design of the button! Thanks for this!

@nikyraja and I agree that we're happy that there should just be a transfer button, and not delete. Technically, children could be discharged but then they would be ineligible for the audit.

Maybe we could add a tooltip saying that if the patient is not being followed up/discharged, they are ineligible for the audit.