rcpch / rcpch-audit-engine

Epilepsy12 Audit Platform
https://e12.rcpch.ac.uk/
GNU Affero General Public License v3.0
5 stars 5 forks source link

KPI data download for April #895

Closed AmaniKrayemRCPCH closed 5 months ago

AmaniKrayemRCPCH commented 6 months ago

We're hoping to update our Power BI dashboard on Wednesday 1st May. Can we be sent the KPI data download for May, as outlined in https://github.com/rcpch/rcpch-audit-engine/issues/791

Trust mergers don't need to be actioned by then, as we can action these before publication.

mbarton commented 6 months ago

I'll keep a list of issues that need to be fixed here as I or others raise them:

Blockers

Nice to have

AmaniKrayemRCPCH commented 6 months ago

The below issue may affect this

mbarton commented 6 months ago

Thanks @AmaniKrayemRCPCH! @eatyourpeas and I will review that issue asap

mbarton commented 6 months ago

@AmaniKrayemRCPCH the download KPI button is now live in staging. It's a little confusingly placed on the organisation page even though it gives you data across all orgs but is only visible to RCPCH admins:

Capture

Could you try and it let me know if there's anything obviously missing. We'll investigate #901 before deploying this to production and of course can do some more rounds if the data isn't correct there, given staging has very limited data.

AmaniKrayemRCPCH commented 6 months ago

Thanks @mbarton!

I've put some comments below in order of priority. I believe we can correct all of these ourselves after downloading, but it would be helpful if these were resolved (particularly the first one).

mbarton commented 6 months ago

Thanks so much for having a look!

The issue with trusts makes sense, I had to remove those changes from the last PR to get our tests to pass. I will try and put them back.

The other changes are easy fixes - I should be able to get to them this week.

dc2007git commented 6 months ago

@AmaniKrayemRCPCH would you like the Country_level sheet to also follow the order of Country, Measure, Percentage, Numerator, Denominator?

AmaniKrayemRCPCH commented 6 months ago

Yes please

dc2007git commented 6 months ago

Great thank you @AmaniKrayemRCPCH - and would you also like columns such as NHSregionMeasure in NHSregion_level to be removed? i.e. the reordering list above is explicit, and each sheet mentioned should have only 5 columns?

AmaniKrayemRCPCH commented 6 months ago

Yep that's correct

mbarton commented 5 months ago

We believe the issues with the report showing data for one group against another one incorrectly are now resolved (https://github.com/rcpch/rcpch-audit-engine/pull/941)