Don't try to divide missing fields and ensure empty cells if missing row or fields

rcpch / rcpch-audit-engine

Epilepsy12 Audit Platform

https://e12.rcpch.ac.uk/

GNU Affero General Public License v3.0

5 stars 5 forks source link

Don't try to divide missing fields and ensure empty cells if missing row or fields #903

Closed mbarton closed 4 months ago

mbarton commented 4 months ago

Follow up to #902 that fixes #899 by skipping that row and logging a message.

Also ensure that if the KPI row or fields are missing the corresponding cells in the report are empty rather than 0 as I believe this is how the PowerBI processing expects it (we'll check this before rolling out to prod)

mbarton commented 4 months ago

As with #902, this passed CI and will be used to investigate an issue in staging so I am going to merge this without a review.

If anyone sees anything to modify please do let me know and I'll raise an additional PR :)