rcpch / rcpch-audit-engine

Epilepsy12 Audit Platform
https://e12.rcpch.ac.uk/
GNU Affero General Public License v3.0
5 stars 5 forks source link

Eatyourpeas/issue901 #909

Closed eatyourpeas closed 4 months ago

eatyourpeas commented 4 months ago

Overview

The PR contains far more fixes than first appears The issue raised (901) identified that KPIs were scoring incomplete when they should scored fail under 2 sets of circumstances:

  1. If MRI not performed, both dates by default were None and this scored incomplete.
  2. Individualised care plan submeasures scored incomplete if they were unscored because there was no plan in place. In both of these cases, an extra check has been put in place for this situation, so that these situations now return Fail

This then of course led the tests relating to KPIs 5, 9 and 10 to fail, so these have been changed.

Code changes

Changes made to scorekpi* files 5,9 and 10, test_measure_9B

Documentation changes (done or required as a result of this PR)

No implications - this is a fix

Related Issues

closes #901

Mentions

thanks @amanikrayem