rcpch / rcpch-audit-engine

Epilepsy12 Audit Platform
https://e12.rcpch.ac.uk/
GNU Affero General Public License v3.0
5 stars 5 forks source link

Derive list of trusts for KPI report from organisations #920

Closed mbarton closed 3 months ago

mbarton commented 4 months ago

This automatically excludes trusts that are not relevant to the audit.

Fixes #912

mbarton commented 3 months ago

Thanks for the comments - I think it's important to spot check this data as much as we can.

In the spreadsheet generated at country level I am seeing ... 2 rows for each measure - is that one set of measures for each country (England and Wales)? How do we know which country is which?

Yes that looks like a mistake. I've raised an issue for it: https://github.com/rcpch/rcpch-audit-engine/issues/924

At trust level, the ODS code is present, but no name column? Is that correct? ... I am not sure how many trusts finally E12 are asking us to use

I'm not sure about which columns are required. The template spreadsheet in #791 has sitename, network_name, network_acr, country, nhsregion and icb, none of which we have in our current export. But Amani commented here to re-arrange the columns only including HBT, Measure, Percentage, Numerator, Denominator as we do currently. I think we will need to confirm again with the team.

Either way I have spot checked the ODS codes in the report against the list of relevant trusts they provided and I don't think we are missing any or have any additional ones. There are some codes in their list that our not in the report but those are the mergers we have already actioned on the platform.

At all other levels, the results are ordered by measure, not ICB, is that right? I can see arguments for doing it both ways?

Yes there's https://github.com/rcpch/rcpch-audit-engine/issues/915 to re-order the columns