955 the request to make laterality have an unknown option
964 errors saving a general paediatric centre when it is also the lead epilepsy12 centre
963 filtering epilepsy12user list error - query looking for organisation.organisation.trust, rather than organisation.trust
Along the way also fixed an error, for which there is no issue, relating to dates in the antiepilepsy medicines/rescue medicines whereby the set button for rescue medicines remained disabled as there was a clash in div id's.
Code changes
For #955 adds a new field to the Episode model, logic to the helper functions for recalculate_form_generate_response, changes to the constants which hold lists of all the focal epilepsy onset types, changes to the focal_onset_epilepsy_checked_changed function in the multiaxial diagnosis view and changes to the focal_onset_epilepsy.html template
for #964 updates to the update_site_model in assessment_views.py refactors the update_fields so that only the flag relating to the centre_role is updated, not all the fields. This was leading to errors in the console particularly where users were saving a centre as a general paediatric centre which was the same as the lead centre and then reallocating, leading to the old record not being removed.
Associated with this, changes to the templates relating to centres for general paediatrics, neurology and epilepsy surgery, where the blue target was missing for unscored fields.
for #963 filter_term_Q has been refactored to compare organisation objects, not organisation names in the comparison, and remove the erroneous extra organisation in organisation.organisation.trust.name breaking the filter
undocumented issue in antiepilepsy_medicine.html where the id for the set button is allocated twice (since the partial is reused for rescue medicines). This led to the button remaining disabled in rescue medicines. By using the tooltip_id parameter, this allowed a unique id to be applied to that div and the buttons therefor to work independently.
Documentation changes (done or required as a result of this PR)
All bug fixes.
Related Issues
closes #955, #963, #964
Mentions
@mentions of the person or team responsible for reviewing proposed changes.
Overview
This PR will close a few issues
955 the request to make laterality have an unknown option
964 errors saving a general paediatric centre when it is also the lead epilepsy12 centre
963 filtering epilepsy12user list error - query looking for organisation.organisation.trust, rather than organisation.trust
Along the way also fixed an error, for which there is no issue, relating to dates in the antiepilepsy medicines/rescue medicines whereby the set button for rescue medicines remained disabled as there was a clash in div id's.
Code changes
recalculate_form_generate_response, changes to the constants which hold lists of all the focal epilepsy onset types, changes to thefocal_onset_epilepsy_checked_changedfunction in the multiaxial diagnosis view and changes to thefocal_onset_epilepsy.htmltemplateupdate_site_modelinassessment_views.pyrefactors the update_fields so that only the flag relating to thecentre_roleis updated, not all the fields. This was leading to errors in the console particularly where users were saving a centre as a general paediatric centre which was the same as the lead centre and then reallocating, leading to the old record not being removed. Associated with this, changes to the templates relating to centres for general paediatrics, neurology and epilepsy surgery, where the blue target was missing for unscored fields.filter_term_Qhas been refactored to compare organisation objects, not organisation names in the comparison, and remove the erroneous extra organisation inorganisation.organisation.trust.namebreaking the filterantiepilepsy_medicine.htmlwhere the id for the set button is allocated twice (since the partial is reused for rescue medicines). This led to the button remaining disabled in rescue medicines. By using thetooltip_idparameter, this allowed a unique id to be applied to that div and the buttons therefor to work independently.Documentation changes (done or required as a result of this PR)
All bug fixes.
Related Issues
closes #955, #963, #964
Mentions
@mentions of the person or team responsible for reviewing proposed changes.