search

rcppmlpack / rcppmlpack2

Rcpp Interface to mlpack (version 2.1.0 and up)
GNU General Public License v2.0
24 stars 9 forks source link

Spelling correction. #2

Closed MHenderson closed 7 years ago

eddelbuettel commented 7 years ago

Good catch.

As you noticed, this doesn't yet build / install. The error made no sense to me:

[...]
conftest.cpp:20:2: error: #error "This is not a C++11 compiler"
 #error "This is not a C++11 compiler"
  ^
configure:3964: $? = 1
configure: failed program was:
[...]

So I think this is due to not having updated the interface. After making changes to function interfaces you must run Rcpp::compileAttributes(). RStudio can do that for you.

Can you run this (worst case: by hand or via this helper script) and the try locally to see if R CMD check .... passes? If so, please update the PR which I will be happy to take once it builds again.

MHenderson commented 7 years ago

That seems to have done the trick. Thanks.

eddelbuettel commented 7 years ago

Should probably be neighbors in plural. I'll get to that....