search

rcr / rirc

A terminal IRC client in C
https://rcr.io/rirc/
MIT License
142 stars 17 forks source link

Scrollback blocked until new message while resizing client #18

Closed ghost closed 7 years ago

ghost commented 8 years ago

Then, I can not scroll while I resized the client. I use it in either DVTM, tmux, abduco, X11.

If i reduce the size, and then increase it again, I can retrieve all of the text (eventually the whole buffer), so content does not seems to be lost.

To me, this has lower priority than logs, as I could browse logs to check mhat is not on screen.

rcr commented 8 years ago

Yeah this has been a known issue for a while...

My first inclination is that this is a bug in how lines are split. I'm already working on replacing the word wrap algorithm since noticing that it actually fails test cases when compiled un-optimized, there's some undefined behaviour, I think the character one before the beginning of the array is being accessed. Once I have a fix for that in place if it's still not working I'll look into the actual draw routine and see if there's an issue there.

ghost commented 8 years ago

I'm impressed that you implemented a ncurses alternative that still works well.

I wrote quite a lot of messages, and I hope it is not a problem to you. I will stop flooding your inbox, as holidays are over.

ghost commented 8 years ago

Maybe it is related to your latest commits: as soon as anything is sent (a command, a message...), the scrollback seems to work again. So it was not really lost, but just blocked.

rcr commented 7 years ago

Finally got around to putting in a temp. fix (awaiting for much needed refactoring) for this long overdue bug.

ghost commented 7 years ago

Thank you!

Besides, it is nice to see program with terminal UI not using ncurses, I am learning much from draw.c.