Closed ghost closed 9 years ago
Thanks for the contribution, I appreciate the help.
Made some comments inline, if you'd like to --amend your commit
thanks for the notes,
if we will keep /RAW, it will force the user to do something like: /RAW whois IRC_NICK
Instead of (it's more convenient): /whois IRC_NICK
i wrote send_cmd_exists()
just for this reason.
but if you want to keep it (it's your project :smiley:) i will rewrite it.
Actually I meant keeping /raw alongside your changes. I use it quite a bit for testing, and it allows the user to send arbitrary commands that might be supported by the server but isn't specifically listed as a command in rirc.
So "/whois nick" and "/raw WHOIS nick" would be equivalent
Updated,
another segfault i found:
I think free_input is causing the segfault. It might be a change I made last commit to input.c.
This is why I really need to come up with some tests :smiley: That's going to be a major task which I plan to do soon.
i added the "R" mode for "registered nicknames only",
you can merge it now :smiley:
UMODE_MAX should be bumped to 8 and then I'll merge
diff 1:
diff 2: