search

rcrowe / TwigBridge

Give the power of Twig to Laravel
MIT License
895 stars 165 forks source link

Fix PHP 8 TypeError #417

Closed bytestream closed 2 years ago

bytestream commented 2 years ago

Fixes:

TypeError : method_exists(): Argument #1 ($object_or_class) must be of type object|string, array given
bytestream commented 2 years ago

@barryvdh please could we get this on a 0.12 branch as well? I can create another PR if you create the branch.

barryvdh commented 2 years ago

Sure

bytestream commented 2 years ago

Please could you create the 0.12 branch? (:

barryvdh commented 2 years ago

But aren't we still on 0.12? Or what is the issue?

bytestream commented 2 years ago

The primary issue is that dev-master is now using twig/twig v3 and I'm not ready to upgrade - I'll just stick to my fork if you prefer.

https://github.com/rcrowe/TwigBridge/compare/v0.12.3...master

barryvdh commented 2 years ago

Ah yes should probably bump to 0.13 and create a 0.12 branch from the latest version.

bytestream commented 2 years ago

Agreed :+1:

bytestream commented 2 years ago

Ah yes should probably bump to 0.13 and create a 0.12 branch from the latest version.

Please could you do those two things? :crossed_fingers: I'll send another PR with this to the 0.12 branch and then we can tag 0.12.4

barryvdh commented 2 years ago

Yes done.