Normalize event view names like Laravel

[rudiedirkx]

EventNode::triggerLaravelEvents() triggers events with the given template name, not the normalized name. Laravel (in ManagesEvents::addViewEvent()) saves events with the normalized name.

In my project I use / delimiters everywhere, because it's much more readable than Laravel's ., and that works (in Laravel and in Twig) because names are normalized. Except in custom triggering events since the Twig 3 upgrade.

I feel like EventNode should do a

$viewName = ViewName::normalize($templateName);

like View\Factory::normalizeName() does. But maybe I'm too me-focused right now. Laravel does the same for the first/main template render. I call it with view('home/index') in the controller, and Laravel (not TwigBridge) calls events for home.index. TwigBridge should do the same?

---

Something weird happens with the first/main template though. If I add a composer('*') listener, and print the $view->name() in the callback, I get the FULL path, AND the normalized path home.index. Only for the first/main template, not the includes and layouts called further in. Sounds a bit like #154 but not quite, and that's super old.

Some illustration (dump($view->name) in my composer('*')'s callback):

• I call view('home/index') in my controller. Laravel triggers event for home.index
• Somehow (through TwigBridge, I can see that in the trace, but not really where/how) an event for the full path is triggered
• TwigBridge triggers the parent view's event (unnormalized theme/page-default)
• And then that view's parent view (unnormalized theme/html)

---

Also, why is there a sprintf in EventNode::compile()?

[rudiedirkx]

422 was first LOL

I am still curious about the full path event though....

[hsingh124]

@rudiedirkx I am having a similar issue with the paths that you mentioned. Was there any fix found for this? I made an issue here for it: https://github.com/rcrowe/TwigBridge/issues/438

I'm having a problem where my view composers aren't being triggered because it's using the path instead of the template name.

[rudiedirkx]

I only noticed it, I didn't have a problem with it, so it didn't really look into it.

[hsingh124]

Thanks for the update, @rudiedirkx. Thats all good, thanks anyway.