search

rcrowe / TwigBridge

Give the power of Twig to Laravel
MIT License
894 stars 168 forks source link

Fix deprecation messages for dynamic property creation with PHP 8.2+ #431

Closed kblais closed 10 months ago

kblais commented 1 year ago

In PHP 8.2, dynamic property creation was deprecated.

The constructors of 2 extensions were still creating a property (see #428)

This PR just created the properties, with the proper docblock.

MaxKorlaar commented 1 year ago

These warnings are bugging me as well – would love to see this PR get merged!

rudiedirkx commented 1 year ago

Oh yeah we definitely need this soon.

sander3 commented 10 months ago

Could this be merged? 👀

kblais commented 10 months ago

Thanks @barryvdh