Contact client implementation authors about splitting off into new libraries

rcrowley / go-metrics

Go port of Coda Hale's Metrics library

Other

3.43k stars 493 forks source link

Contact client implementation authors about splitting off into new libraries #121

Open mihasya opened 8 years ago

mihasya commented 8 years ago

[x] @mihasya for Librato
[x] Michael Crosby for Influx
[x] @bketelsen for Stathat
[x] @cyberdelia for Graphite
[ ] huxiao for OpenTSDB

Other libraries to document:

[ ] Riemann by @pingles https://github.com/rcrowley/go-metrics/pull/71

cyberdelia commented 8 years ago

From the gist of it, it sounds like a good idea, maybe you could share some details you have in mind?

mihasya commented 8 years ago

Howdy! Basically, just spinning the individual reporters that require an external dependency (like a service) into their own little repos that import go-metrics and are referenced in go-metrics README and docs, but are otherwise independent. So many of the issues and PRs are for things like Stathat InfluxDB, which none of the maintainers of go-metrics use, so they just languish. I think it's a more maintainable path forward.

cyberdelia commented 8 years ago

@mihasya Any preferences on the naming of theses "spin-off" ?

mihasya commented 8 years ago

@cyberdelia hmm.. not entirely sure, but I also don't think it's worth agonizing over. They'll theoretically only be imported once, in main.go, correct?

mihasya commented 8 years ago

@cyberdelia probably something like metrics-graphite or similar will work just fine.

mihasya commented 8 years ago

@cyberdelia you can see my stab at the Librato client's move here https://github.com/rcrowley/go-metrics/pull/122

cyberdelia commented 8 years ago

For graphite: https://github.com/cyberdelia/go-metrics-graphite

mihasya commented 8 years ago

@cyberdelia nice and easy. Thanks!

bketelsen commented 8 years ago

I don't use the stathat lib at all, if someone else wants to take ownership - I'm happy to relinquish any "control"

mihasya commented 8 years ago

@bketelsen thanks for letting us know. We'll find it a home, even if it's just under my account with a "MAINTAINER WANTED" in the README.

mihasya commented 8 years ago

It looks like the github account for Michael Crosby is @crosbymichael. Michael, would you be interested in becoming the maintainer for a split-out version of the influx reporter?

crosbymichael commented 8 years ago

@mihasya ya, i can take the influx part

mihasya commented 8 years ago

@crosbymichael Beauty! Please check out the repos myself and @cyberdelia have created for librato and graphite

slayer commented 8 years ago

http://prometheus.io/ looks like a candidate for the creation of a client

talbright commented 8 years ago

Is there something inherently incompatible with statsd and this library, that there isn't an exporter for it?