Stop timer/meter - Githubissues

rcrowley / go-metrics

Go port of Coda Hale's Metrics library

Other

3.46k stars 494 forks source link

Closed inooka-shiroyuki closed 6 years ago

inooka-shiroyuki commented 7 years ago

added Stop to timer.
call Stop when metrics are unregistered.
use lock in meter Stop() to avoid data races accessing the stopped flag.
when called meter Mark(), return if meter is already stopped (without panicking).

mihasya commented 7 years ago

(am in the middle of a bunch of travel and a conference, will try to take a look soon.. leaving the tab open)

inooka-shiroyuki commented 6 years ago

@mihasya thanks!