rcrowley / go-metrics

Go port of Coda Hale's Metrics library
Other
3.46k stars 494 forks source link

Add dump method for standard registry #216

Closed sakateka closed 6 years ago

sakateka commented 7 years ago

This method will allow the library user to export the metrics as yaml or any other format.

sakateka commented 6 years ago

@mihasya PTAL

mihasya commented 6 years ago

Thanks for getting my attention, sorry I didn't look sooner.

Please rename "Dump" to "GetAll" as it more accurately describes what you're adding, esp given there's already a Get(name string) method.

Otherwise, looks good. Thanks!

mihasya commented 6 years ago

😎