Adding a snapshot type that can be extended

rcrowley / go-metrics

Go port of Coda Hale's Metrics library

Other

3.43k stars 493 forks source link

Adding a snapshot type that can be extended #267

Closed nikunjy closed 3 years ago

nikunjy commented 4 years ago

What do you think @rcrowley @mihasya

nikunjy commented 4 years ago

Is this repository dead ?

mihasya commented 4 years ago

Not quite dead, but it's unfortunately not currently part of anybody's full-time job to monitor it. As a result, things go in fits and starts. The time commitment to review something is extended by having to context switch into a repo I don't think about regularly. Sorry about this, I'll try to find time to review the PR soon.

nikunjy commented 4 years ago

The tests will have to change a little bit because I am introducing a new type. Instead of returning won types Snapshot() returns a type of Snapshot() and Snapshot is a read copy. The tests don't have any significant change.

nikunjy commented 3 years ago

Closing it as I don't think I will merge it.