search

rcrowley / go-tigertonic

A Go framework for building JSON web services inspired by Dropwizard
Other
997 stars 79 forks source link

Added ResponseErrorWriter interface to allow for custom error json ma… #90

Closed keithballdotnet closed 9 years ago

keithballdotnet commented 9 years ago

…rshalling. Added tests to ensure backward compatibilty

Please review and merge.

keithballdotnet commented 9 years ago

Refactored taking into account what you said. The other errors, I am ok with being in the tigertonic format.

keithballdotnet commented 9 years ago

Finally twigged what you meant. The calls are now made in place. All places that did similar error output have been centralised into using the ResponseErrorWriter functions.

keithballdotnet commented 9 years ago

Where possible code also uses 

ResponseErrorWriter.WritePlaintextError(w, notFoundErr)

where appropriate.

willfaught commented 9 years ago

LGTM

I'm not the repo owner, though; one of them will have to accept the PR. Is one of them watching? :)

mihasya commented 9 years ago

@willfaught @Inflatablewoman Hi hi, yes, been tracking since the original issue. Will take a look at it this week, unless @wadey gets to it first.

keithballdotnet commented 9 years ago

The sooner the better would be great, I need to get this into a build by the end of the week. Would prefer to not use my fork if I dont have to. Any estimate?

mihasya commented 9 years ago

:+1: