Closed kitschpatrol closed 4 months ago
I saw your pull request and appreciate you helping out on this plugin. However, I try to keep dependencies to only important ones. In previous versions, there used to be an "Include subfolders" toggle. It seems to be a good way to avoid pulling in dependencies and keep the plugin fast and lightweight. I'll have to think about just adding it back in or considering your pull request despite the additional dependecy.
Hi, thanks for responding.
Glob matching is one of those things that seems trivial, but is tricky to get right. It's absolutely worth a dependency to use a proven implementation. (I'm actually surprised there isn't a glob library exposed through Obsidian's plugin API...)
But that said, I threw in the glob approach because I didn't want to mess with your settings UI, and I hadn't seen the previous version with a subfolders toggle. It's great if that could be brought back, and it's probably more intuitive for most Obsidian users than glob patterns.
I'll just use my fork, thanks.
Thanks for this plugin, it works great!
It would be really handy to be able to enable it on an entire sub-tree of folders, maybe with a glob pattern or a "recursive" flag in the settings.