search

rcsb / mmtf-cpp

The pure C++ implementation of the MMTF API, decoder and encoder.
MIT License
21 stars 24 forks source link

Add installer stage to cmake #22

Closed danpf closed 5 years ago

danpf commented 5 years ago

Detailed in README.md, but now you can install with: cmake -G Ninja -Dmmtf_install_system=ON .. ninja install

and mmtf-cpp will installed to /usr/local/include

danpf commented 5 years ago

reference to issue #20 and #18

gtauriello commented 5 years ago

@frodofine Do you have any idea why the CI for EMSCRIPTEN=ON failed here? There is nothing useful in the log in travis and so I hoped that maybe you have an educated guess there...

danpf commented 5 years ago

i think github CI is down so we can wait for that if you want... I don't know anything about emscripten

gtauriello commented 5 years ago

As I see my review comment got duplicated. Github was acting up earlier today. Sorry for that.

And yes we should wait for some input from @frodofine on how to fix the emscripten part since I think he is the only one that knows about that...

danpf commented 5 years ago

well it works now.... So i think the error was just due to github going down.

speleo3 commented 5 years ago

One more thing: The "Installation" section in the README sounds very repetitive with the already existing "How to use MMTF" section. Generally, I would avoid such repetition and keep the README concise.