search

rcsb / mmtf-cpp

The pure C++ implementation of the MMTF API, decoder and encoder.
MIT License
21 stars 24 forks source link

Extra data tests #29

Closed gtauriello closed 5 years ago

gtauriello commented 5 years ago

I noticed that our tests for extra data had two short-comings:

  1. We added atom properties vectors which didn't have numAtoms as length
  2. We never tested the other extra data fields

I extended the tests to cover these two things.

gtauriello commented 5 years ago

And in the process I also changed the code to use the style used elsewhere (indentation with spaces and avoiding long lines). Since this makes it a bit harder to check the changes, please use the URL below to see changes without whitespace-changes (just adding "?w=1" to the comparison-URL): https://github.com/rcsb/mmtf-cpp/pull/29/files?w=1

Please review my changes and approve them if you think they are ok.