search

rcsb / mmtf-cpp

The pure C++ implementation of the MMTF API, decoder and encoder.
MIT License
21 stars 24 forks source link

Update mmtf_tests.cpp #41

Closed kevinsmia1939 closed 3 years ago

kevinsmia1939 commented 3 years ago

This fix issue catch not found. Previous issue https://github.com/rcsb/mmtf-cpp/issues/39

gtauriello commented 3 years ago

@kevinsmia1939 Your proposed change breaks our tests and can hence not be accepted. Also your proposed change requires a specific directory structure for Catch2 which makes the code less portable. I would hence propose that you leave the include command unchanged and instead modify the cmake file to enable a configurable CATCH_INCLUDE_DIR if you really need it.

As mentioned in #39, Catch2 is just used to run tests and does not need to be available on your system. Hence, you can safely fetch Catch2 from the git submodules (as described in the README) for the purpose of running the tests and you probably will never need any fix for this.

kevinsmia1939 commented 3 years ago

@kevinsmia1939 Your proposed change breaks our tests and can hence not be accepted. Also your proposed change requires a specific directory structure for Catch2 which makes the code less portable. I would hence propose that you leave the include command unchanged and instead modify the cmake file to enable a configurable CATCH_INCLUDE_DIR if you really need it.

As mentioned in #39, Catch2 is just used to run tests and does not need to be available on your system. Hence, you can safely fetch Catch2 from the git submodules (as described in the README) for the purpose of running the tests and you probably will never need any fix for this.

ok thanks