rcsb / py-rcsb_utils_targets

RCSB module containing methods for target data management
Apache License 2.0
0 stars 0 forks source link

(work in progress)Check cache for valid data from nested provider #18

Closed aliciaaevans closed 1 year ago

aliciaaevans commented 1 year ago

For some of these providers, the nested provider's data is not populated. It is therefore not valid to use them as a basis for the current provider. The idea is to return False if the nested provider testCache returns False.

Note: I have not done extensive testing of this. Also, there might be existing providers or places in these providers that need similar.

This commit (https://github.com/rcsb/py-rcsb_utils_targets/pull/18/commits/d908fda54626c073a18d9130d4ac0d935c7d5c1c) is a suggestion to fix the tests. The test failed because the test data only has 1 item and testCache was checking > minCount. I think minCount should be inclusive.

See also https://github.com/rcsb/py-rcsb_workflow/pull/12