rcsb / symmetry

:ferris_wheel: Detect, analyze, and visualize protein symmetry
GNU Lesser General Public License v2.1
26 stars 16 forks source link

Master #48

Closed lafita closed 9 years ago

lafita commented 9 years ago

Summary of the changes:

In progress:

sbliven commented 9 years ago

Do we need to blank out the break flag in the MatrixListener you implemented in CESymm?

sbliven commented 9 years ago

Does the running time analysis code in SubunitTools.java belong in the core part of CE-Symm?

If so, we should remove the hard-coded paths for the output locations.

lafita commented 9 years ago

The matrix mat contains the information of the blackout from the OrigM matrix, but it is recalculated each optimization iteration with the residue distances. The matrix listener keeps the entries blacked out in this case. The break flag matrix, however, is initialized each iteration and the entries calculated depending on the values in mat, so I deduce that if the matrix mat is blacked out the break flag also acquires the information.

Adding the matrix listener only for mat seems to solve the problem (alignments falling inside the blacked out region) for the structures analysed so far.

lafita commented 9 years ago

The code inside the subunit package that belonged in the core part of CE-Symm has been moved to the corresponding places. The code that is left only saves parts of the calculation for external analysis (like graphs, fasta alignments or running times). I will consider moving this methods to some other I/O package if they become important.

I have changed the hard coded paths and set them as input of the methods.