rcsb / symmetry

:ferris_wheel: Detect, analyze, and visualize protein symmetry
GNU Lesser General Public License v2.1
26 stars 16 forks source link

Use random seed by default in optimization #66

Closed sbliven closed 8 years ago

sbliven commented 8 years ago

The seed is initialized to 0 by default. A better default seed would be the current time or something. It should be random unless the user specifies it.

Also, setting a seed in the gui seems to hang during the alignment.

lafita commented 8 years ago

@sbliven can you give me a test case for the alignment hanging when the seed is changed? I cannot reproduce the bug. Could the hanging be from the optimization taking longer with that seed, or it does not terminate (throws an Exception)?

I have set the default random seed to the last 6 digits of the System.currentTimeMillis() variable. That way it will change every time the user calls CE-Symm unless specified.

lafita commented 8 years ago

See commit changes in biojava.