search

rcseacord / cmp_int

C implementation of C++ Utility functions https://en.cppreference.com/w/cpp/utility/intcmp
MIT License
18 stars 1 forks source link

integer types #1

Closed gustedt closed 3 years ago

gustedt commented 3 years ago

Claiming that this works for "integer types" is kind of weird because it seems that by design it doesn't work for char and bool. I am not questionning that design, but then this should be made cristal clear in the documentation.

AaronBallman commented 3 years ago

This is modelled after the C++20 APIs: https://en.cppreference.com/w/cpp/utility/intcmp

Those APIs explicitly disallow char and bool and I elected to follow the same principles. Those are not types that should be treated as mathematical types. I agree that the documentation should be made more clear on this.

rcseacord commented 3 years ago

Documentation updated.