rctay / sublime-text-buildview

A Sublime Text plugin to show build output in a view.
MIT License
67 stars 7 forks source link

Sublime text 4 support #37

Closed iamgm closed 3 years ago

iamgm commented 3 years ago

I've installed sublime text 4 and it seems that it doesn't support buildview. Moreover buildview menu item in Preferences -> Package settings disappeared. I know there is an alternative of using terminus instead. But I found it not so convenient. Do you have any plans on updating the package?

YoSTEALTH commented 3 years ago

I would also like to see support for sublime text 4. This is a great little feature.

YoSTEALTH commented 3 years ago

You can get this project working for sublime text 4 by replacing if sublime.version().startswith('3'): with if sublime.version().startswith(('3', '4')): in files pipe_views.py and commands.py

Also adding "show_panel_on_build": false, into Preferences -> Setting if you want to hide default build panel

rctay commented 3 years ago

Thanks everyone, let me sort out some Package Control stuff https://github.com/wbond/package_control_channel/pull/8284 and a new release for Sublime Text 4 should be coming soon.

rctay commented 3 years ago

Please try running Package Control: Upgrade Package, you should get the fixes to work on Sublime Text 4. Thanks everyone!

YoSTEALTH commented 3 years ago

The new changes seem to open new build panel on every build vs using the previous one.

could you change:

import re
import sublime, sublime_plugin

if re.match('3|4', sublime.version()):

with:

import sublime
import sublime_plugin
from distutils.version import LooseVersion

if LooseVersion(sublime.version()) >= '3':

for both pipe_views.py and commands.py files.

LooseVersion is proper way to handle version comparison.

Thanks @rctay

rctay commented 3 years ago

Hi @YoSTEALTH, I just tried this using the plugin as published right now, and I couldn't reproduce what you said (new output build panels for every new build).

My setup:

Could you copy/replace the steps above with the steps you used to run into the problem? That would be helpful in reproducing the problem.

iamgm commented 3 years ago

Thanks for replies.

I also have the same issue with new version.

The new changes seem to open new build panel on every build vs using the previous one.

and for me there is no build output in a build tab at all. I don't insist there is a problem in buildview. Most likely it is in my setup.

Also I discovered there are 2 similar packages in package control now. One of them is buildview, and second one is sublime-text-buildview. Tried both. Both gave same results.

Actually I more or less set up terminus + origami pair that day when the issue was opened. But anyway using 2 packages for solving one problem looks like weird workaround.

YoSTEALTH commented 3 years ago

@rctay So I reinstalled the BuildView package and the issue with new tab started happening, But once I closed the sublimetext and reopened it the problem went away. So a manual restart of sublimetext is required.