search

rctn / sparsecoding

Reference sparse coding implementations for efficient learning and inference.
BSD 3-Clause "New" or "Revised" License
17 stars 4 forks source link

bars dataset + priors #30

Closed alvinzz closed 2 years ago

alvinzz commented 2 years ago

Refactor BarsDataset.

Adds Priors:

Updates unittests.

belsten commented 2 years ago

General comment about formatting, we currently have a formatting style guide that is in another branch and will be merged. https://github.com/rctn/sparsecoding/blob/formatting/docs/contributing.md Much of the stable code we have right now follows this guide.

cshewmake2 commented 2 years ago

Thanks for all of the commits! For future reference: let's make sure each branch is adding its own feature. It's a lot easier to review and accept PRs quickly when they're atomic and add a specific new functionality or change.

alvinz-matician commented 2 years ago

Yeah old (bad) habits die hard. If it's too much I'm happy to break it up into smaller PRs. But it would be difficult to split everything from moving the BarsDataset to the last tests change, since the tests depend on that dataset.

cshewmake2 commented 2 years ago

I have yet to test out everything on my local machine. Will try to do that tomorrow sometime.

alvinzz commented 2 years ago

Updated to have Numpy-style docstrings & pruned some commits into other PRs.