search

rcvaram / BNS-scanner

This is basic network scanner that can scan the all devices which are in the connected network and give their ip address and mac address and os version.
Apache License 2.0
18 stars 7 forks source link

removed scapy dependency #7

Closed gnany07 closed 4 years ago

gnany07 commented 4 years ago

Instead of importing whole scapy, imported only necessay modules

rcvaram commented 4 years ago

It is good @gnany07 but I have to remove scapy dependency from the repo

gnany07 commented 4 years ago

okay,you meant to have independent ARP, Ether.. modules from somewhere else? I didn't get the exact intention.

rcvaram commented 4 years ago

I have planned to remove imports of scapy from the repo. Simply, we can copy those relevant files only and get the required things from that file. Do you think, it can be done or not

gnany07 commented 4 years ago

Yeah sure. It can be done. Let me give it a try and then update you.

On Thu, Oct 31, 2019, 11:22 AM Sivaram notifications@github.com wrote:

I have planned to remove imports of scapy from the repo. Simply, we can copy those relevant files only and get the required things from that file. Do you think, it can be done or not

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cvaram96/BNS-scanner/pull/7?email_source=notifications&email_token=AJEMLUMAOZLRN3XI7QI4EE3QRJXAHA5CNFSM4JGPHEFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECWUM6I#issuecomment-548226681, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJEMLULHWVDRRQ2NL2MW543QRJXAHANCNFSM4JGPHEFA .

gnany07 commented 4 years ago

Hi ram, I tried decouple the scapy package from the project. I could get the each modules source code but the hard part here is all these are implemented with lot of inter-dependency with other modules and have some decorators

rcvaram commented 4 years ago

Not good as a straight forward answer from me, Don't worry I will look at it and update it later