search

rcvd / logseq-craft-theme

Craft Theme for Logseq
MIT License
39 stars 6 forks source link

Craft and Bullet Threading not playing nice #3

Open xavez opened 2 years ago

xavez commented 2 years ago

When I install both the Craft Theme and the Bullet Threading plugin, the styles get a bit mixed up:

CleanShot 2022-05-05 at 14 12 35@2x

I managed to fix it by resetting the .block-children-left-border class's z-index to unset. This is what it looks like after:

CleanShot 2022-05-05 at 14 23 43@2x

I'm not 100% certain the cause is the Craft theme because it's a bit opaque to me how to investigate where which CSS is coming from. However: disabling the theme makes the problem go away, and enabling the theme makes the problem appear again, so I think it's quite safe to assume it's a conflict between Craft and the Bullet Threading plugin :-)

d3v1an7 commented 2 years ago

Can confirm! Just adding a bit more flavour to the above: Bullet threading plugin is here: https://github.com/pengx17/logseq-plugin-bullet-threading

I am including the bullet threading plugin via CSS. So with the fix above, my custom css looks like this:

@import url('https://rcvd.github.io/logseq-craft-theme/craft.css');
@import url("https://cdn.jsdelivr.net/gh/pengx17/logseq-dev-theme@master/bullet_threading.css");
.block-children-left-border { z-index: unset; }