"verify" does commit changes when transaction mode is set to "version"

rdagumampan / yuniql

Free and open source schema versioning and database migration made natively with .NET/6. NEW THIS MAY 2022! v1.3.15 released!

https://yuniql.io

Apache License 2.0

417 stars 63 forks source link

"verify" does commit changes when transaction mode is set to "version" #279

Open rioka opened 2 years ago

rioka commented 2 years ago

When you run yuniql verify, and transaction-mode is set to "version", changes are persisted anyway, because each set of changes is wrapped in a separate transaction, and each transaction is eventually committed.

yuniql verify -c "Data source=..." -p path/to/migrations --transaction-mode "version"

This may be "by design", but it should be documented anyway as it's quite unexpected behavior IMHO.

rdagumampan commented 2 years ago

Hi @rioka , thanks for feedback! It can only get better thru tickets like this, appreciate it. Certainly its not an intended behavior. It was clever to set transaction-mode in an uncommitted run. I hope find time very soon to further investigate. I'll put into into priority. Thanks again.