rdallasgray / graphene

A set of defaults for Emacs, for refugees from GUI text editors.
321 stars 29 forks source link

smartparens removed sp-autoescape-string-quote-if-empty #33

Closed hartzell closed 8 years ago

hartzell commented 8 years ago

I'm hitting this error after an update to my world:

Debugger entered--Lisp error: (void-variable sp-autoescape-string-quote-if-empty)
  add-to-list(sp-autoescape-string-quote-if-empty coffee-mode)
  byte-code("\302\303\304\305\306$\210\302\307\304\305\310$\210\311\312\313\211\314\315\316\317&\210\320\304\211\2030   @\321\322\"\210   A\211\204!*\323\324!\207" [mode --dolist-tail-- sp-pair "{" nil :post-handlers (:add ((lambda (id action context) (graphene--sp-pair-on-newline-and-indent id action context)) "RET")) "[" (:add ((lambda (id action context) (graphene--sp-pair-on-newline-and-indent id action context)) "RET")) sp-local-pair (markdown-mode gfm-mode) "*" :unless (sp-in-string-p) :actions (insert wrap) (coffee-mode shell-mode) add-to-list sp-autoescape-string-quote-if-empty provide graphene-smartparens-config] 9)
  require(graphene-smartparens-config)
  #[nil "\301\302!\210\301\303!\210\304\211\207" [sp-highlight-pair-overlay require smartparens-config graphene-smartparens-config nil] 2]()
  eval-after-load(smartparens #[nil "\301\302!\210\301\303!\210\304\211\207" [sp-highlight-pair-overlay require smartparens-config graphene-smartparens-config nil] 2])
  byte-code("\300\301\302\"\210\303\304\305\306\307\310\311\312&\207" [eval-after-load smartparens #[nil "\301\302!\210\301\303!\210\304\211\207" [sp-highlight-pair-overlay require smartparens-config graphene-smartparens-config nil] 2] custom-declare-variable graphene-completion-auto (quote global) "Whether graphene should enable autocomplete with prog-modes." :type sexp :group graphene] 8)
  require(graphene-editing)
  byte-code("\300\301\302\303\304\305%\210\306\307!\210\306\310!\210\306\311!\210\306\312!\210\306\313!\210\314\301!\207" [custom-declare-group graphene nil "Graphene custom settings." :group environment require graphene-helper-functions graphene-editing graphene-env graphene-projects graphene-look provide] 6)
  require(graphene)
  eval-buffer(#<buffer  *load*> nil "/Users/hartzelg/.emacs.d/init.el" nil t)  ; Reading at buffer position 1787
  load-with-code-conversion("/Users/hartzelg/.emacs.d/init.el" "/Users/hartzelg/.emacs.d/init.el" t t)
  load("/Users/hartzelg/.emacs.d/init" t t)
  #[0 "\205\262   \306=\203\307\310Q\202; \311=\204\307\312Q\202;\313\307\314\315#\203*\316\202;\313\307\314\317#\203:\320\nB\321\202;\316\322\323\322\211#\210\322=\203a\324\325\326\307\327Q!\"\323\322\211#\210\322=\203`\210\203\243\330!\331\232\203\243\332!\211\333P\334!\203}\211\202\210\334!\203\207\202\210\314\262\203\241\335\"\203\237\336\337#\210\340\341!\210\266\f?\205\260\314\323\342\322\211#)\262\207" [init-file-user system-type delayed-warnings-list user-init-file inhibit-default-init inhibit-startup-screen ms-dos "~" "/_emacs" windows-nt "/.emacs" directory-files nil "^\\.emacs\\(\\.elc?\\)?$" "~/.emacs" "^_emacs\\(\\.elc?\\)?$" (initialization "`_emacs' init file is deprecated, please use `.emacs'") "~/_emacs" t load expand-file-name "init" file-name-as-directory "/.emacs.d" file-name-extension "elc" file-name-sans-extension ".el" file-exists-p file-newer-than-file-p message "Warning: %s is newer than %s" sit-for 1 "default"] 7 "\n\n(fn)"]()
  command-line()
  normal-top-level()

It looks like this recent commit in the smartparens package removed the variable, and that it had been deprecated back in Feb 07, 2015.

michaelsilver commented 8 years ago

Any update on a solution/workaround? This is currently preventing graphene from working for me.

hartzell commented 8 years ago

I commented out lines 58 and 59 in graphene-smartparens-config.el.

Not elegant, but it has me up and running. I'm not a coffescript user and not a smart-parens sophisticate, so I'm not sure what a good fix would be....

michaelsilver commented 8 years ago

@rdallasgray any plans for a new release to fix this graphene-breaking bug?

hartzell commented 8 years ago

I've submitted a PR that fixes it, probable need to explicitly depend on the recent smartparens.