search

rdallasgray / pallet

A package management tool for Emacs, built on Cask.
279 stars 15 forks source link

V0.7 #34

Closed rdallasgray closed 9 years ago

rdallasgray commented 9 years ago
rdallasgray commented 9 years ago

@rejeep -- Would you mind reviewing this? I'm trying to bring pallet into line a bit, with a view to possibly opening up contribution.

rejeep commented 9 years ago

@rdallasgray Sure thing. Maybe I'll have some time this weekend to look it over.

rdallasgray commented 9 years ago

Much appreciated, thanks.

rejeep commented 9 years ago

Sorry, had no time over this weekend, will do it as soon as I can.

rdallasgray commented 9 years ago

Hey, no problem. Whenever you can manage.

rejeep commented 9 years ago

I had a few minor comments in the code. Other than that, it looks great! Should be much easier to contribute to the project now.

It might not be in the scope of this PR as it has not changed, but I would use EPL to allow easier testing on multiple Emacs versions. It would also make the tests easier.

I really like that you made it a mode!

I tried it out locally and it works just fine. But tests does not pass on emacs-git-snapshot (Evm):

(file-error "http://127.0.0.1:9191/packages/archive-contents" "Internal server error")
rdallasgray commented 9 years ago

Hey, thanks a lot for doing that. I'll look into the test failures. Ideally I want to get it working under Vagrant with several different Emacsen tested.

rejeep commented 9 years ago

The code probably works just fine. Just figured it's probably a good idea to run the tests on the complete 24 series.