rdallasgray / pallet

A package management tool for Emacs, built on Cask.
279 stars 15 forks source link

Ensure newline at EOF #40

Closed sambrightman closed 9 years ago

rdallasgray commented 9 years ago

Thanks for this.

First, why's it necessary?

And if it is necessary, why not add the newline here?: https://github.com/rdallasgray/pallet/blob/master/pallet.el#L194

That way we always add it at EOF.

sambrightman commented 9 years ago

It is conventional to end text files with newlines and several tools will note/warn/suggest if they are missing.

I chose the location because there is already an intention to add a newline between the non-ignored and ignored text: this way if you have no ignored text then you have a newline at the end of the file and if you have some ignored text you already control the end of it yourself (note the removal of the extra "\n" concat).