search

rdaly525 / coreir

BSD 3-Clause "New" or "Revised" License
100 stars 24 forks source link

google test throws sign conversion warnings #1025

Open rdaly525 opened 2 years ago

rdaly525 commented 2 years ago 
/Users/ross/dev/coreir/build/tests/gtest/googletest-src/googletest/src/gtest.cc:4082:33: error: implicit conversion changes signedness: 'const char' to 'unsigned char' [-Werror,-Wsign-conversion]
        if (IsValidXmlCharacter(ch)) {
            ~~~~~~~~~~~~~~~~~~~ ^~
/Users/ross/dev/coreir/build/tests/gtest/googletest-src/googletest/src/gtest.cc:4083:56: error: implicit conversion changes signedness: 'const char' to 'unsigned char' [-Werror,-Wsign-conversion]
          if (is_attribute && IsNormalizableWhitespace(ch))
                              ~~~~~~~~~~~~~~~~~~~~~~~~ ^~
/Users/ross/dev/coreir/build/tests/gtest/googletest-src/googletest/src/gtest.cc:4104:29: error: implicit conversion changes signedness: 'const char' to 'unsigned char' [-Werror,-Wsign-conversion]