search

rdaly525 / coreir

BSD 3-Clause "New" or "Revised" License
101 stars 24 forks source link

Pass "packbitconstants" assertion failure #379

Closed makaimann closed 6 years ago

makaimann commented 6 years ago

I get the following complaint when trying to use the packbitconstants pass: coreir: wiring_utils.cpp:185: CoreIR::Select CoreIR::getDriverSelect(CoreIR::Select): Assertion `false' failed.

In the attached file is a small example that just adds two inputs and produces that failure. I had to use .txt because GitHub didn't like .json but it's a coreir json file.

Thanks!

adder.txt

dillonhuff commented 6 years ago

Unfortunately packbitconstants is currently a no-op, so there is no reason to use it anyway.

Do you actually need to pack bit constants into coreir constants? If so I can work on implementing it for real

dillonhuff commented 6 years ago

Also for future reference could you send coreir json files with the .json extension just to keep things clean?

dillonhuff commented 6 years ago

Ah, just read the second paragraph of your message. Thats very strange.

makaimann commented 6 years ago

Yeah, I'm not sure why they only allow certain file extensions.

And don't worry about it -- I don't actually need it. I just noticed the implementation of Mantle's Add with cin which uses a bunch of bit_gnd constants and thought it would be good to pack them. It's not necessary though.

makaimann commented 6 years ago

Should I close the issue or do you want to leave it for later?

rdaly525 commented 6 years ago

@dillonhuff is there a bug here?

dillonhuff commented 6 years ago

No, I just need to implement this pass later if someone needs it